Show white filled check mark icon #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbharadwaj
commented
Oct 13, 2025
adbharadwaj
commented
Oct 13, 2025
| return ( | ||
| <svg className={className} width={width} height={height} viewBox={viewBox} style={style} xmlns="http://www.w3.org/2000/svg"> | ||
| <path d="M8 0C3.6 0 0 3.6 0 8s3.6 8 8 8 8-3.6 8-8-3.6-8-8-8z" fill={color} /> | ||
| <path d="M7 11.4L3.6 8 5 6.6l2 2 4-4L12.4 6 7 11.4z" fill={checkColor || 'transparent'} /> |
Contributor
Author
There was a problem hiding this comment.
allows me to control the color of the checkmark separately from fill color and background color.
glebovsky
reviewed
Oct 14, 2025
| function Check (props) { | ||
| const path = 'M8 0C3.6 0 0 3.6 0 8s3.6 8 8 8 8-3.6 8-8-3.6-8-8-8zM7 11.4L3.6 8 5 6.6l2 2 4-4L12.4 6 7 11.4z' | ||
| return <Icon path={path} {...props} /> | ||
| function Check ({ color, className, path, viewBox, width, height, style, checkColor }) { |
Member
There was a problem hiding this comment.
I suggest setting some defaults here like width, height and viewBox
Contributor
Author
There was a problem hiding this comment.
I wont do it in this case because we do not set defaults for them in case of other icons.
glebovsky
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we want:
What we get without this change: (all fill colors to try)
